Luxxy/beegoon
Watch
1
0
Fork
You've already forked beegoon
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Wait for an image pull to actually finish before reporting success #8

Merged
Luxxy merged 1 commit from phase-2-3-inventory-operations into main 2026-08-02 22:45:59 +00:00
Conversation 0 Commits 1 Files changed 1 +23
Luxxy commented 2026-08-02 22:45:53 +00:00
Owner
Copy link

pull_image reported success as soon as Incus accepted the pull request,
not when the transfer completed — POST /1.0/images answers immediately
and downloads in the background. That let a pull operation show
Succeeded while the image was still transferring, which the new
automatic post-pull inventory refresh would then immediately fail to
find, since it hadn't landed yet.

Uses wait_for_operation, which was already implemented and tested but
never called anywhere, to block until Incus's own operation actually
finishes or fails.

Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com

pull_image reported success as soon as Incus accepted the pull request, not when the transfer completed — POST /1.0/images answers immediately and downloads in the background. That let a pull operation show Succeeded while the image was still transferring, which the new automatic post-pull inventory refresh would then immediately fail to find, since it hadn't landed yet. Uses wait_for_operation, which was already implemented and tested but never called anywhere, to block until Incus's own operation actually finishes or fails. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Wait for an image pull to actually finish before reporting success
Some checks failed
Agent CI / Test the agent (pull_request) Failing after 2s
Details
Backend CI / Migrations apply to an empty database (pull_request) Failing after 1s
Details
Security / Advisories, licences and sources (pull_request) Failing after 2s
Details
Agent CI / Against a real Incus daemon (pull_request) Has been skipped
Details
Backend CI / Format, lint and test (pull_request) Failing after 2s
Details
Security / No secrets or placeholder credentials committed (pull_request) Failing after 2s
Details
Security / Frontend dependency audit (pull_request) Failing after 38s
Details
Agent CI / The workspace still compiles off Linux (pull_request) Has been cancelled
Details
61cd343d13 
pull_image reported success as soon as Incus accepted the pull request,
not when the transfer completed — POST /1.0/images answers immediately
and downloads in the background. That let a pull operation show
Succeeded while the image was still transferring, which the new
automatic post-pull inventory refresh would then immediately fail to
find, since it hadn't landed yet.

Uses wait_for_operation, which was already implemented and tested but
never called anywhere, to block until Incus's own operation actually
finishes or fails.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Luxxy merged commit a3d75f5b38 into main 2026-08-02 22:45:59 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Luxxy/beegoon!8
No description provided.